2021-04-22 13:36:53 +02:00
|
|
|
From a6d475147682de1fe3b14eb325f4247e013e8440 Mon Sep 17 00:00:00 2001
|
|
|
|
Message-Id: <a6d475147682de1fe3b14eb325f4247e013e8440.1619091389.git.sbrivio@redhat.com>
|
|
|
|
In-Reply-To: <ba51349d353f11e05c6341a7e065f2ade3874c68.1619091389.git.sbrivio@redhat.com>
|
|
|
|
References: <ba51349d353f11e05c6341a7e065f2ade3874c68.1619091389.git.sbrivio@redhat.com>
|
2021-03-17 10:57:45 +01:00
|
|
|
From: Stefano Brivio <sbrivio@redhat.com>
|
2021-04-22 13:36:53 +02:00
|
|
|
Date: Wed, 21 Apr 2021 18:52:16 +0200
|
2021-03-17 10:57:45 +01:00
|
|
|
Subject: [PATCH 2/2] net: Don't ignore EINVAL on netdev socket connection
|
|
|
|
|
|
|
|
Other errors are treated as failure by net_socket_connect_init(),
|
|
|
|
but if connect() returns EINVAL, we'll fail silently. Remove the
|
|
|
|
related exception.
|
|
|
|
|
|
|
|
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
|
|
|
|
---
|
2021-10-19 12:43:28 +02:00
|
|
|
SPDX-FileCopyrightText: 2020-2021 Red Hat GmbH <sbrivio@redhat.com>
|
|
|
|
SPDX-License-Identifier: AGPL-3.0-or-later
|
|
|
|
|
2021-03-17 10:57:45 +01:00
|
|
|
net/socket.c | 3 +--
|
|
|
|
1 file changed, 1 insertion(+), 2 deletions(-)
|
|
|
|
|
|
|
|
diff --git a/net/socket.c b/net/socket.c
|
2021-04-22 13:36:53 +02:00
|
|
|
index aadd11dae2b3..d3293ac12e82 100644
|
2021-03-17 10:57:45 +01:00
|
|
|
--- a/net/socket.c
|
|
|
|
+++ b/net/socket.c
|
2021-04-22 13:36:53 +02:00
|
|
|
@@ -644,8 +644,7 @@ static int net_socket_connect_init(NetClientState *peer,
|
2021-03-17 10:57:45 +01:00
|
|
|
if (errno == EINTR || errno == EWOULDBLOCK) {
|
|
|
|
/* continue */
|
|
|
|
} else if (errno == EINPROGRESS ||
|
|
|
|
- errno == EALREADY ||
|
|
|
|
- errno == EINVAL) {
|
|
|
|
+ errno == EALREADY) {
|
|
|
|
break;
|
|
|
|
} else {
|
|
|
|
error_setg_errno(errp, errno, "can't connect socket");
|
|
|
|
--
|
2021-04-22 13:36:53 +02:00
|
|
|
2.29.2
|
2021-03-17 10:57:45 +01:00
|
|
|
|