mirror of
https://passt.top/passt
synced 2025-05-28 12:25:34 +02:00
tests: Add pane_status command to check for success of issued commands
When we use pane_wait to wait for a command issued to a tmux pane to finish we have no idea whether the command succeeded or not. This means that the test scripts can keep running long after the point something vital has failed, making it difficult to work out what went wrong. Add a new pane_status command that checks for success of the issued command and use it in most places instead of pane_wait. We still need explicit pane_wait where we're gathering explicit output with pane_parse, because the way we check the status with 'echo $?' means we lose track of that output. Signed-off-by: David Gibson <david@gibson.dropbear.id.au> [sbrivio: - instead of quitting the script, make a test fail if a command issued in a pane fails during a test, and loop until the status code is numeric in pane_status() as a hack to make it a bit more robust - retain usage of pane_wait() in iperf3 and teardown functions as we interrupt iperf3, passt, and pasta, so a non-zero exit code is expected - drop bogus ns_{1,2}_wait() calls in teardown_two_guests(), those functions were never implemented - use pane_status() for "guest" test directives too ] Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
This commit is contained in:
parent
3e0641f91f
commit
13ad716f30
3 changed files with 59 additions and 50 deletions
test/lib
|
@ -228,6 +228,20 @@ pane_parse() {
|
|||
printf '%s' "${__buf}" || printf '@EMPTY@'
|
||||
}
|
||||
|
||||
# pane_status() - Wait for command to complete and return its exit status
|
||||
# $1: Pane name
|
||||
pane_status() {
|
||||
pane_wait "${1}"
|
||||
__status="$(pane_parse "${1}")"
|
||||
while ! [ "${__status}" -eq "${__status}" ]; do
|
||||
sleep 1
|
||||
pane_run "${1}" 'echo $?'
|
||||
pane_wait "${1}"
|
||||
__status="$(pane_parse "${1}")"
|
||||
done
|
||||
return ${__status}
|
||||
}
|
||||
|
||||
# status_file_end() - Display and log messages when tests from one file are done
|
||||
status_file_end() {
|
||||
[ -z "${STATUS_FILE}" ] && return
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue