mirrors/passt
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

udp: drop bogus udp_tap_map ts assignment

Browse source 
The 'ts' field is a timestamp so assigning the socket file descriptor is
incorrect. There is no actual bug because the current time is assigned
just a few lines later:

      udp_tap_map[V4][src].sock = s;
      udp_tap_map[V4][src].ts = s;
      ^^^^^^^^^^^ bogus ^^^^^^^^^^
      bitmap_set(udp_act[V4][UDP_ACT_TAP], src);
  }

  udp_tap_map[V4][src].ts = now->tv_sec;
  ^^^^^^^^^^^^^^^ correct ^^^^^^^^^^^^^^

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
This commit is contained in:
Stefan Hajnoczi 2021-10-15 11:27:17 +01:00 committed by Stefano Brivio
parent 6231422dfb
commit 14fe73e766
1 changed files with 0 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
udp.c
View file

@ -927,7 +927,6 @@ int udp_tap_handler(struct ctx *c, int af, void *addr,
return count;
udp_tap_map[V4][src].sock = s;
udp_tap_map[V4][src].ts = s;
bitmap_set(udp_act[V4][UDP_ACT_TAP], src);
}