mirrors/passt
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

pcap: Update pcap_frame() to take an iovec and offset

Browse source 
Update the low-level helper pcap_frame() to take a struct iovec and
offset within it, rather than an explicit pointer and length for the
frame.  This moves the handling of an offset (to skip vnet_len) from
pcap_multiple() to pcap_frame().

This doesn't accomplish a great deal immediately, but will make
subsequent changes easier.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
This commit is contained in:
David Gibson 2024-02-28 12:52:02 +11:00 committed by Stefano Brivio
parent 64b63d9e3e
commit 24410b37a4
1 changed files with 12 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
pcap.c
View file

@ -67,24 +67,25 @@ struct pcap_pkthdr {
/** /**
* pcap_frame() - Capture a single frame to pcap file with given timestamp * pcap_frame() - Capture a single frame to pcap file with given timestamp
* @pkt: Pointer to data buffer, including L2 headers * @iov: IO vector referencing buffer containing frame (with L2 headers)
* @len: L2 packet length * @offset: Offset of the frame from @iov->iov_base
* @tv: Timestamp * @tv: Timestamp
* *
* Returns: 0 on success, -errno on error writing to the file * Returns: 0 on success, -errno on error writing to the file
*/ */
static int pcap_frame(const char *pkt, size_t len, const struct timeval *tv) static void pcap_frame(const struct iovec *iov, size_t offset,
const struct timeval *tv)
{ {
size_t len = iov->iov_len - offset;
struct pcap_pkthdr h; struct pcap_pkthdr h;
h.tv_sec = tv->tv_sec; h.tv_sec = tv->tv_sec;
h.tv_usec = tv->tv_usec; h.tv_usec = tv->tv_usec;
h.caplen = h.len = len; h.caplen = h.len = len;
if (write(pcap_fd, &h, sizeof(h)) < 0 || write(pcap_fd, pkt, len) < 0) if (write(pcap_fd, &h, sizeof(h)) < 0 ||
return -errno; write(pcap_fd, (char *)iov->iov_base + offset, len) < 0)
debug("Cannot log packet, length %zu", len);
return 0;
} }
/** /**
@ -94,14 +95,14 @@ static int pcap_frame(const char *pkt, size_t len, const struct timeval *tv)
*/ */
void pcap(const char *pkt, size_t len) void pcap(const char *pkt, size_t len)
{ {
struct iovec iov = { (char *)pkt, len };
struct timeval tv; struct timeval tv;
if (pcap_fd == -1) if (pcap_fd == -1)
return; return;
gettimeofday(&tv, NULL); gettimeofday(&tv, NULL);
if (pcap_frame(pkt, len, &tv) != 0) pcap_frame(&iov, 0, &tv);
debug("Cannot log packet, length %zu", len);
} }
/** /**
@ -120,14 +121,8 @@ void pcap_multiple(const struct iovec *iov, unsigned int n, size_t offset)
gettimeofday(&tv, NULL); gettimeofday(&tv, NULL);
for (i = 0; i < n; i++) { for (i = 0; i < n; i++)
if (pcap_frame((char *)iov[i].iov_base + offset, pcap_frame(iov + i, offset, &tv);
iov[i].iov_len - offset, &tv) != 0) {
debug("Cannot log packet, length %zu",
iov->iov_len - offset);
return;
}
}
} }
/** /**