mirrors/passt
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

test: Slight simplification to pasta log tests

Browse source 
test/pasta_options/log_to_file contains a couple of rudimentary tests
where we start pasta with an interactive shell, then immediately exit it.
We can achieve the same thing by using /bin/true as the command to pasta.
This also means that waiting for pasta to start, waiting for the executed
command to complete and for pasta to clean up are all handled by simply
waiting for pasta to complete in the foreground, so there's no need for an
additional sleep.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
This commit is contained in:
David Gibson 2024-04-24 14:29:59 +10:00 committed by Stefano Brivio
parent 0804fdbc28
commit 2681366966
1 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
test/pasta_options/log_to_file
View file

@ -33,15 +33,11 @@ test Log creation
set PORTS -t 10001,10002 -u 10001,10002 set PORTS -t 10001,10002 -u 10001,10002
set LOG_FILE __STATEDIR__/pasta.log set LOG_FILE __STATEDIR__/pasta.log
passt ./pasta -l __LOG_FILE__ passt ./pasta -l __LOG_FILE__ -- /bin/true
passtb exit
sleep 1
check [ -s __LOG_FILE__ ] check [ -s __LOG_FILE__ ]
test Log truncated on creation test Log truncated on creation
passt ./pasta -l __LOG_FILE__ passt ./pasta -l __LOG_FILE__ -- /bin/true
passtb exit
sleep 1
check [ $(cat __LOG_FILE__ | wc -l) -eq 1 ] check [ $(cat __LOG_FILE__ | wc -l) -eq 1 ]
test Maximum log size test Maximum log size