mirrors/passt
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

conf: Fix clang-tidy warning about using an undefined enum value

Browse source 
In conf() we temporarily set the forwarding mode variables to 0 - an
invalid value, so that we can check later if they've been set by the
intervening logic.  clang-tidy 18.1.1 in Fedora 40 now complains about
this.  Satisfy it by giving an name in the enum to the 0 value.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
This commit is contained in:
David Gibson 2024-05-14 00:57:57 +10:00 committed by Stefano Brivio
parent 26c71db332
commit 29bd08ff0f
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
conf.c
View file

@ -1203,8 +1203,8 @@ void conf(struct ctx *c, int argc, char **argv)
optstring = "dqfel:hs:F:p:P:m:a:n:M:g:i:o:D:S:461t:u:"; optstring = "dqfel:hs:F:p:P:m:a:n:M:g:i:o:D:S:461t:u:";
} }
c->tcp.fwd_in.mode = c->tcp.fwd_out.mode = 0; c->tcp.fwd_in.mode = c->tcp.fwd_out.mode = FWD_UNSET;
c->udp.fwd_in.f.mode = c->udp.fwd_out.f.mode = 0; c->udp.fwd_in.f.mode = c->udp.fwd_out.f.mode = FWD_UNSET;
do { do {
name = getopt_long(argc, argv, optstring, options, NULL); name = getopt_long(argc, argv, optstring, options, NULL);

1
fwd.h
View file

@ -11,6 +11,7 @@
#define NUM_PORTS (1U << 16) #define NUM_PORTS (1U << 16)
enum fwd_ports_mode { enum fwd_ports_mode {
FWD_UNSET = 0,
FWD_SPEC = 1, FWD_SPEC = 1,
FWD_NONE, FWD_NONE,
FWD_AUTO, FWD_AUTO,