mirrors/passt
1
0
Fork 0
mirror of https://passt.top/passt synced 2025-07-27 11:48:01 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

flow: Fix clang error (clang-analyzer-security.PointerSub)

Browse source 
Fixes the following clang-analyzer warning:

flow_table.h:96:25: note: Subtraction of two pointers that do not point into the same array is undefined behavior
   96 |         return (union flow *)f - flowtab;

The `flow_idx()` function is called via `FLOW_IDX()` from
`flow_foreach_slot()`, where `f` is set to `&flowtab[idx].f`.
Therefore, `f` and `flowtab` do point to the same array.

Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
This commit is contained in:
Laurent Vivier 2025-05-13 11:41:02 +02:00 • committed by Stefano Brivio
commit 2d3d69c5c3
1 changed files with 1 additions and 0 deletions

1
flow_table.h
View file

@ -93,6 +93,7 @@ extern union flow flowtab[];
*/ */
static inline unsigned flow_idx(const struct flow_common *f) static inline unsigned flow_idx(const struct flow_common *f)
{ {
/* NOLINTNEXTLINE(clang-analyzer-security.PointerSub) */
return (union flow *)f - flowtab; return (union flow *)f - flowtab;
} }