clang-tidy: Suppress silly misc-include-cleaner warnings

clang-tidy from LLVM 17.0.3 (which is in Fedora 39) includes a new
"misc-include-cleaner" warning that tries to make sure that headers
*directly* provide the things that are used in the .c file.  That sounds
great in theory but is in practice unusable:

Quite a few common things in the standard library are ultimately provided
by OS-specific system headers, but for portability should be accessed via
closer-to-standardised library headers.  This will warn constantly about
such cases: e.g. it will want you to include <linux/limits.h> instead of
<limits.h> to get PATH_MAX.

So, suppress this warning globally in the Makefile.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
This commit is contained in:
David Gibson 2023-11-15 13:59:45 +11:00 committed by Stefano Brivio
parent 5ec3634b07
commit 3be9e0010e

View file

@ -250,6 +250,12 @@ docs: README.md
# - bugprone-assignment-in-if-condition # - bugprone-assignment-in-if-condition
# Dubious value over the compiler's built-in warning. Would # Dubious value over the compiler's built-in warning. Would
# increase verbosity. # increase verbosity.
#
# - misc-include-cleaner
# Wants to include headers which *directly* provide the things
# we use. That sounds nice, but means it will often want a OS
# specific header instead of a mostly standard one, such as
# <linux/limits.h> instead of <limits.h>.
clang-tidy: $(SRCS) $(HEADERS) clang-tidy: $(SRCS) $(HEADERS)
clang-tidy -checks=*,-modernize-*,\ clang-tidy -checks=*,-modernize-*,\
@ -275,7 +281,8 @@ clang-tidy: $(SRCS) $(HEADERS)
-readability-function-cognitive-complexity,\ -readability-function-cognitive-complexity,\
-altera-struct-pack-align,\ -altera-struct-pack-align,\
-concurrency-mt-unsafe,\ -concurrency-mt-unsafe,\
-readability-identifier-length \ -readability-identifier-length,\
-misc-include-cleaner \
-config='{CheckOptions: [{key: bugprone-suspicious-string-compare.WarnOnImplicitComparison, value: "false"}]}' \ -config='{CheckOptions: [{key: bugprone-suspicious-string-compare.WarnOnImplicitComparison, value: "false"}]}' \
--warnings-as-errors=* $(SRCS) -- $(filter-out -pie,$(FLAGS) $(CFLAGS) $(CPPFLAGS)) -DCLANG_TIDY_58992 --warnings-as-errors=* $(SRCS) -- $(filter-out -pie,$(FLAGS) $(CFLAGS) $(CPPFLAGS)) -DCLANG_TIDY_58992