mirrors/passt
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

netlink: In nl_addr() and nl_route(), don't return before set request

Browse source 
Fixes: 22ed4467a4 ("treewide: Unchecked return value from library, CWE-252")
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
This commit is contained in:
Stefano Brivio 2022-05-01 06:55:49 +02:00
parent 3c6ae62510
commit 3f2e7098ac
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
netlink.c
View file

@ -328,7 +328,7 @@ void nl_route(int ns, unsigned int ifi, sa_family_t af, void *gw)
req.nlh.nlmsg_flags |= NLM_F_DUMP; req.nlh.nlmsg_flags |= NLM_F_DUMP;
} }
if (set || (n = nl_req(ns, buf, &req, req.nlh.nlmsg_len)) < 0) if ((n = nl_req(ns, buf, &req, req.nlh.nlmsg_len)) < 0 || set)
return; return;
nh = (struct nlmsghdr *)buf; nh = (struct nlmsghdr *)buf;
@ -435,7 +435,7 @@ void nl_addr(int ns, unsigned int ifi, sa_family_t af,
req.nlh.nlmsg_flags |= NLM_F_DUMP; req.nlh.nlmsg_flags |= NLM_F_DUMP;
} }
if (set || (n = nl_req(ns, buf, &req, req.nlh.nlmsg_len)) < 0) if ((n = nl_req(ns, buf, &req, req.nlh.nlmsg_len)) < 0 || set)
return; return;
nh = (struct nlmsghdr *)buf; nh = (struct nlmsghdr *)buf;