mirrors/passt
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

log: Match implicit va_start() with va_end() in vlogmsg()

Browse source 
According to C99, 7.15.1:

  Each invocation of the va_start and va_copy macros shall be matched
  by a corresponding invocation of the va_end macro in the same
  function

and the same applies to C11. I still have to come across a platform
where va_end() actually does something, but thus spake the standard.
This would be reported by Coverity as "Missing varargs init or
cleanup" (CWE-573).

Fixes: c0426ff10b ("log: Add vlogmsg()")
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
This commit is contained in:
Stefano Brivio 2023-11-07 12:17:07 +01:00
parent 9494a51a4e
commit 50bc25a23c
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
log.c
View file

@ -67,6 +67,8 @@ void vlogmsg(int pri, const char *format, va_list ap)
logfile_write(pri, format, ap2); logfile_write(pri, format, ap2);
else if (!(setlogmask(0) & LOG_MASK(LOG_DEBUG))) else if (!(setlogmask(0) & LOG_MASK(LOG_DEBUG)))
passt_vsyslog(pri, format, ap2); passt_vsyslog(pri, format, ap2);
va_end(ap2);
} }
if ((setlogmask(0) & LOG_MASK(LOG_DEBUG) && log_file == -1) || if ((setlogmask(0) & LOG_MASK(LOG_DEBUG) && log_file == -1) ||