From 684870a766e7f024a5720464ad070e666cb4793e Mon Sep 17 00:00:00 2001 From: David Gibson <david@gibson.dropbear.id.au> Date: Tue, 1 Apr 2025 19:57:10 +1100 Subject: [PATCH] udp: Correct some seccomp filter annotations Both udp_buf_listen_sock_data() and udp_buf_reply_sock_data() have comments stating they use recvmmsg(). That's not correct, they only do so via udp_sock_recv() which lists recvmmsg() itself. In contrast udp_splice_send() and udp_tap_handler() both directly use sendmmsg(), but only the latter lists it. Add it to the former as well. Signed-off-by: David Gibson <david@gibson.dropbear.id.au> Signed-off-by: Stefano Brivio <sbrivio@redhat.com> --- udp.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/udp.c b/udp.c index 44b58d1..ab3e9d2 100644 --- a/udp.c +++ b/udp.c @@ -272,6 +272,8 @@ static void udp_splice_prepare(struct mmsghdr *mmh, unsigned idx) * @dst: Destination port for datagrams (target side) * @ref: epoll reference for origin socket * @now: Timestamp + * + * #syscalls sendmmsg */ static void udp_splice_send(const struct ctx *c, size_t start, size_t n, flow_sidx_t tosidx) @@ -662,8 +664,6 @@ static int udp_sock_recv(const struct ctx *c, int s, struct mmsghdr *mmh) * @c: Execution context * @ref: epoll reference * @now: Current timestamp - * - * #syscalls recvmmsg */ static void udp_buf_listen_sock_data(const struct ctx *c, union epoll_ref ref, const struct timespec *now) @@ -760,8 +760,6 @@ void udp_listen_sock_handler(const struct ctx *c, * @tosidx: Flow & side to forward data from @s to * * Return: true on success, false if can't forward from socket to flow's pif - * - * #syscalls recvmmsg */ static bool udp_buf_reply_sock_data(const struct ctx *c, int s, flow_sidx_t tosidx)