mirrors/passt
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

icmp: Warn on receive errors from ping sockets

Browse source 
Currently we silently ignore an errors receiving a packet from a ping
socket.  We don't expect that to happen, so it's probably worth reporting
if it does.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
This commit is contained in:
David Gibson 2024-01-16 16:16:16 +11:00 committed by Stefano Brivio
parent a325121759
commit 6e86511f59
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
icmp.c
View file

@ -81,8 +81,11 @@ void icmp_sock_handler(const struct ctx *c, int af, union epoll_ref ref)
return;
n = recvfrom(ref.fd, buf, sizeof(buf), 0, &sr.sa, &sl);
if (n < 0)
if (n < 0) {
warn("%s: recvfrom() error on ping socket: %s",
pname, strerror(errno));
return;
}
if (af == AF_INET) {
struct icmphdr *ih4 = (struct icmphdr *)buf;