mirrors/passt
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

conf, passt.1: Don't imply --foreground with --debug

Browse source 
Having -f implied by -d (and --trace) usually saves some typing, but
debug mode in background (with a log file) is quite useful if pasta
is started by Podman, and is probably going to be handy for passt
with libvirt later, too.

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
This commit is contained in:
Stefano Brivio 2022-10-26 16:48:42 +02:00
parent e4df8b0844
commit 7402951658
2 changed files with 5 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
conf.c
View file

@ -636,7 +636,7 @@ static void usage(const char *name)
info(""); info("");
info( " -d, --debug Be verbose, don't run in background"); info( " -d, --debug Be verbose");
info( " --trace Be extra verbose, implies --debug"); info( " --trace Be extra verbose, implies --debug");
info( " -q, --quiet Don't print informational messages"); info( " -q, --quiet Don't print informational messages");
info( " -f, --foreground Don't run in background"); info( " -f, --foreground Don't run in background");
@ -1192,7 +1192,7 @@ void conf(struct ctx *c, int argc, char **argv)
usage(argv[0]); usage(argv[0]);
} }
c->trace = c->debug = c->foreground = 1; c->trace = c->debug = 1;
break; break;
case 12: case 12:
if (runas) { if (runas) {
@ -1233,7 +1233,6 @@ void conf(struct ctx *c, int argc, char **argv)
} }
c->debug = 1; c->debug = 1;
c->foreground = 1;
break; break;
case 'e': case 'e':
if (logfile) { if (logfile) {
@ -1275,7 +1274,7 @@ void conf(struct ctx *c, int argc, char **argv)
c->quiet = 1; c->quiet = 1;
break; break;
case 'f': case 'f':
if (c->foreground && !c->debug) { if (c->foreground) {
err("Multiple --foreground options given"); err("Multiple --foreground options given");
usage(argv[0]); usage(argv[0]);
} }

5
passt.1
View file

@ -79,12 +79,11 @@ for performance reasons.
.TP .TP
.BR \-d ", " \-\-debug .BR \-d ", " \-\-debug
Be verbose, don't run in background, don't log to the system logger. Be verbose, don't log to the system logger.
.TP .TP
.BR \-\-trace .BR \-\-trace
Be extra verbose, show single packets, don't run in background. Implies Be extra verbose, show single packets. Implies \fB--debug\fR.
\fB--debug\fR.
.TP .TP
.BR \-q ", " \-\-quiet .BR \-q ", " \-\-quiet