mirrors/passt
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

pasta, tcp: Don't set TCP_CORK on spliced sockets

Browse source 
...throughput isn't everything: this leads (of course) to horrible
latency with small, sparse messages. As a consequence, there's no
need to set TCP_NODELAY either.

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
This commit is contained in:
Stefano Brivio 2021-09-16 08:24:00 +02:00
parent a7eb8bb2f6
commit 7ecf693297
1 changed files with 1 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
tcp.c
View file

@ -2380,19 +2380,14 @@ static int tcp_splice_connect(struct ctx *c, struct tcp_splice_conn *conn,
.sin_addr = { .s_addr = htonl(INADDR_LOOPBACK) }, .sin_addr = { .s_addr = htonl(INADDR_LOOPBACK) },
}; };
const struct sockaddr *sa; const struct sockaddr *sa;
int ret, one = 1;
socklen_t sl; socklen_t sl;
int ret;
if (sock_conn < 0) if (sock_conn < 0)
return -errno; return -errno;
conn->to = sock_conn; conn->to = sock_conn;
setsockopt(conn->from, SOL_TCP, TCP_CORK, &one, sizeof(one));
setsockopt(conn->from, SOL_TCP, TCP_NODELAY, &one, sizeof(one));
setsockopt(conn->to, SOL_TCP, TCP_CORK, &one, sizeof(one));
setsockopt(conn->to, SOL_TCP, TCP_NODELAY, &one, sizeof(one));
if (v6) { if (v6) {
sa = (struct sockaddr *)&addr6; sa = (struct sockaddr *)&addr6;
sl = sizeof(addr6); sl = sizeof(addr6);