From 86bdd968ea2df977b40b5120c13672ca6ee98c79 Mon Sep 17 00:00:00 2001 From: David Gibson Date: Mon, 12 Aug 2024 19:53:53 +1000 Subject: [PATCH] Correct inaccurate comments on ip[46]_ctx::addr These fields are described as being an address for an external, routable interface. That's not necessarily the case when using -a. But, more importantly, saying where the value comes from is not as useful as what it's used for. The real purpose of this field is as the address which we assign to the guest via DHCP or --config-net. Signed-off-by: David Gibson Signed-off-by: Stefano Brivio --- passt.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/passt.h b/passt.h index 12ae1b9..ef68403 100644 --- a/passt.h +++ b/passt.h @@ -91,7 +91,7 @@ enum passt_modes { /** * struct ip4_ctx - IPv4 execution context - * @addr: IPv4 address for external, routable interface + * @addr: IPv4 address assigned to guest * @addr_seen: Latest IPv4 address seen as source from tap * @prefixlen: IPv4 prefix length (netmask) * @gw: Default IPv4 gateway @@ -121,7 +121,7 @@ struct ip4_ctx { /** * struct ip6_ctx - IPv6 execution context - * @addr: IPv6 address for external, routable interface + * @addr: IPv6 address assigned to guest * @addr_ll: Link-local IPv6 address on external, routable interface * @addr_seen: Latest IPv6 global/site address seen as source from tap * @addr_ll_seen: Latest IPv6 link-local address seen as source from tap