mirror of
https://passt.top/passt
synced 2025-05-23 01:35:35 +02:00
passt-repair: Correct off-by-one error verifying name
passt-repair will generate an error if the name it gets from the kernel is
too long or not NUL terminated. Downstream testing has reported
occasionally seeing this error in practice.
In turns out there is a trivial off-by-one error in the check: ev->len is
the length of the name, including terminating \0 characters, so to check
for a \0 at the end of the buffer we need to check ev->name[len - 1] not
ev->name[len].
Fixes: 42a854a52
("pasta, passt-repair: Support multiple events per...")
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
This commit is contained in:
parent
dadf2aa269
commit
8fed562e63
1 changed files with 1 additions and 1 deletions
|
@ -157,7 +157,7 @@ int main(int argc, char **argv)
|
|||
}
|
||||
} while (!found);
|
||||
|
||||
if (ev->len > NAME_MAX + 1 || ev->name[ev->len] != '\0') {
|
||||
if (ev->len > NAME_MAX + 1 || ev->name[ev->len - 1] != '\0') {
|
||||
fprintf(stderr, "Invalid filename from inotify\n");
|
||||
_exit(1);
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue