From 947d756747bfe938d95c3cbc163d148b54e03d68 Mon Sep 17 00:00:00 2001 From: Stefano Brivio Date: Wed, 26 Oct 2022 17:01:12 +0200 Subject: [PATCH] tap: Trace received (outbound) ICMP packets in debug mode, too This only worked for ICMPv6: ICMP packets have no TCP-style header, so they are handled as a special case before packet sequences are formed, and the call to tap_packet_debug() was missing. Fixes: bb708111833e ("treewide: Packet abstraction with mandatory boundary checks") Signed-off-by: Stefano Brivio Reviewed-by: David Gibson --- tap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tap.c b/tap.c index 3f78c99..4dcff4f 100644 --- a/tap.c +++ b/tap.c @@ -463,6 +463,8 @@ resume: if (c->no_icmp) continue; + tap_packet_debug(iph, NULL, NULL, 0, NULL, 1); + packet_add(pkt, l4_len, l4h); icmp_tap_handler(c, AF_INET, &iph->daddr, pkt, now); continue;