mirrors/passt
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tcp: Fix ACK reporting on older kernels (no tcp.kernel_snd_wnd case)

Browse source 
If the window isn't updated on !c->tcp.kernel_snd_wnd, we still
have to send ACKs if the ACK sequence was updated, or if an error
occurred while querying TCP_INFO.

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
This commit is contained in:
Stefano Brivio 2021-10-19 09:13:53 +02:00
parent 5496074862
commit 9e065b1448
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
tcp.c
View file

@ -1558,16 +1558,16 @@ static int tcp_update_seqack_wnd(struct ctx *c, struct tcp_tap_conn *conn,
if (!c->tcp.kernel_snd_wnd) { if (!c->tcp.kernel_snd_wnd) {
tcp_get_sndbuf(conn); tcp_get_sndbuf(conn);
conn->wnd_to_tap = MIN(conn->snd_buf, MAX_WINDOW); conn->wnd_to_tap = MIN(conn->snd_buf, MAX_WINDOW);
return 0; goto out;
} }
if (!info) { if (!info) {
if (conn->wnd_to_tap > WINDOW_DEFAULT) if (conn->wnd_to_tap > WINDOW_DEFAULT)
return 0; goto out;
info = &__info; info = &__info;
if (getsockopt(s, SOL_TCP, TCP_INFO, info, &sl)) if (getsockopt(s, SOL_TCP, TCP_INFO, info, &sl))
return 0; goto out;
} }
if (conn->local || tcp_rtt_dst_low(conn)) { if (conn->local || tcp_rtt_dst_low(conn)) {
@ -1579,6 +1579,7 @@ static int tcp_update_seqack_wnd(struct ctx *c, struct tcp_tap_conn *conn,
conn->wnd_to_tap = MIN(conn->wnd_to_tap, MAX_WINDOW); conn->wnd_to_tap = MIN(conn->wnd_to_tap, MAX_WINDOW);
out:
return conn->wnd_to_tap != prev_wnd_to_tap || return conn->wnd_to_tap != prev_wnd_to_tap ||
conn->seq_ack_to_tap != prev_ack_to_tap; conn->seq_ack_to_tap != prev_ack_to_tap;
} }