tcp: Avoid false (but convoluted) positive Coverity CWE-476 warning
If there are no TCP options in the header, tcp_tap_handler() will pass the corresponding pointer, fetched via packet_get(), as NULL to tcp_conn_from_sock_finish(), which in turn indirectly calls tcp_opt_get(). If there are no options, tcp_opt_get() will stop right away because the option length is indicated as zero. However, if the logic is complicated enough to follow for static checkers, adding an explicit check against NULL in tcp_opt_get() is probably a good idea. Signed-off-by: Stefano Brivio <sbrivio@redhat.com> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
This commit is contained in:
parent
5474bc5485
commit
a1d5537741
1 changed files with 1 additions and 1 deletions
2
tcp.c
2
tcp.c
|
@ -1114,7 +1114,7 @@ static int tcp_opt_get(const char *opts, size_t len, uint8_t type_find,
|
||||||
{
|
{
|
||||||
uint8_t type, optlen;
|
uint8_t type, optlen;
|
||||||
|
|
||||||
if (!len)
|
if (!opts || !len)
|
||||||
return -1;
|
return -1;
|
||||||
|
|
||||||
for (; len >= 2; opts += optlen, len -= optlen) {
|
for (; len >= 2; opts += optlen, len -= optlen) {
|
||||||
|
|
Loading…
Reference in a new issue