mirrors/passt
1
0
Fork 0
mirror of https://passt.top/passt synced 2025-06-26 08:05:33 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

tcp: Unconditionally move to CLOSED state on tcp_rst()

Browse source 
tcp_rst() attempts to send an RST packet to the guest, and if that succeeds
moves the flow to CLOSED state.  However, even if the tcp_send_flag() fails
the flow is still dead: we've usually closed the socket already, and
something has already gone irretrievably wrong.  So we should still mark
the flow as CLOSED.  That will cause it to be cleaned up, meaning any
future packets from the guest for it won't match a flow, so should generate
new RSTs (they don't at the moment, but that's a separate bug).

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
This commit is contained in:
David Gibson 2025-02-27 16:55:16 +11:00 • committed by Stefano Brivio
parent 56ce03ed0a
commit b2708218a6
1 changed files with 2 additions and 2 deletions

4
tcp.c
View file

@ -1214,8 +1214,8 @@ void tcp_rst_do(const struct ctx *c, struct tcp_tap_conn *conn)
if (conn->events == CLOSED)
return;
if (!tcp_send_flag(c, conn, RST))
conn_event(c, conn, CLOSED);
tcp_send_flag(c, conn, RST);
conn_event(c, conn, CLOSED);
}
/**