mirrors/passt
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tcp: Replace source address also if it's the same as the guest address

Browse source 
...not just for loopback addresses, with the address of the default
gateway. Otherwise, the guest might receive packets with source and
destination set to the same address.

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
This commit is contained in:
Stefano Brivio 2021-07-21 12:05:58 +02:00
parent 1642a04f48
commit b508079c4c
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
tcp.c
View file

@ -1814,7 +1814,8 @@ static void tcp_conn_from_sock(struct ctx *c, union epoll_ref ref,
if (ref.tcp.v6) { if (ref.tcp.v6) {
struct sockaddr_in6 *sa6 = (struct sockaddr_in6 *)&sa; struct sockaddr_in6 *sa6 = (struct sockaddr_in6 *)&sa;
if (IN6_IS_ADDR_LOOPBACK(&sa6->sin6_addr)) if (IN6_IS_ADDR_LOOPBACK(&sa6->sin6_addr) ||
!memcmp(&sa6->sin6_addr, &c->addr6_seen, sizeof(c->addr6)))
memcpy(&sa6->sin6_addr, &c->gw6, sizeof(c->gw6)); memcpy(&sa6->sin6_addr, &c->gw6, sizeof(c->gw6));
memcpy(&conn->a.a6, &sa6->sin6_addr, sizeof(conn->a.a6)); memcpy(&conn->a.a6, &sa6->sin6_addr, sizeof(conn->a.a6));
@ -1835,7 +1836,8 @@ static void tcp_conn_from_sock(struct ctx *c, union epoll_ref ref,
memset(&conn->a.a4.one, 0xff, sizeof(conn->a.a4.one)); memset(&conn->a.a4.one, 0xff, sizeof(conn->a.a4.one));
if (ntohl(sa4->sin_addr.s_addr) == INADDR_LOOPBACK || if (ntohl(sa4->sin_addr.s_addr) == INADDR_LOOPBACK ||
ntohl(sa4->sin_addr.s_addr) == INADDR_ANY) ntohl(sa4->sin_addr.s_addr) == INADDR_ANY ||
sa4->sin_addr.s_addr == c->addr4_seen)
sa4->sin_addr.s_addr = c->gw4; sa4->sin_addr.s_addr = c->gw4;
memcpy(&conn->a.a4.a, &sa4->sin_addr, sizeof(conn->a.a4.a)); memcpy(&conn->a.a4.a, &sa4->sin_addr, sizeof(conn->a.a4.a));