1
0
Fork 0
mirror of https://passt.top/passt synced 2025-05-19 07:55:34 +02:00

tcp: unify l2 TCPv4 and TCPv6 queues and structures

Following the preparations in the previous commit, we can now remove
the payload and flag queues dedicated for TCPv6 and TCPv4 and move all
traffic into common queues handling both protocol types.

Apart from reducing code and memory footprint, this change reduces
a potential risk for TCPv4 traffic starving out TCPv6 traffic.
Since we always flush out the TCPv4 frame queue before the TCPv6 queue,
the latter will never be handled if the former fails to send all its
frames.

Tests with iperf3 shows no measurable change in performance after this
change.

Signed-off-by: Jon Maloy <jmaloy@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
This commit is contained in:
Jon Maloy 2024-10-28 22:14:00 -04:00 committed by Stefano Brivio
parent 2053c36dec
commit ba38e67cf4
3 changed files with 76 additions and 181 deletions

6
tcp.c
View file

@ -2611,11 +2611,7 @@ int tcp_init(struct ctx *c)
{
ASSERT(!c->no_tcp);
if (c->ifi4)
tcp_sock4_iov_init(c);
if (c->ifi6)
tcp_sock6_iov_init(c);
tcp_sock_iov_init(c);
memset(init_sock_pool4, 0xff, sizeof(init_sock_pool4));
memset(init_sock_pool6, 0xff, sizeof(init_sock_pool6));