1
0
Fork 0
mirror of https://passt.top/passt synced 2025-05-29 04:35:33 +02:00

test: Add log file tests for pasta plus corresponding layout and setup

To test log files on a tmpfs mount, we need to unshare the mount
namespace, which means using a context for the passt pane is not
really practical at the moment, as we can't open a shell there, so
we would have to encapsulate all the commands under 'unshare -rUm',
plus the "inner" pasta command, running in turn a tcp_rr server.

It might be worth fixing this by e.g. detecting we are trying to
spawn an interactive shell and adding a special path in the context
setup with some form of stdin redirection -- I'm not sure it's doable
though.

For this reason, add a new layout, using a context only for the host
pane, while keeping the old command dispatch mechanism for the passt
pane.

We also need a new setup function that doesn't start pasta: we want
to start and restart it with different options.

Further, we need a 'pint' directive, to send an interrupt to the
passt pane: add that in lib/test.

All the tests before the one involving tmpfs and a detached mount
namespace were also tested with the context mechanism. To make an
eventual conversion easier, pass tcp_crr directly as a command on
pasta's command line where feasible.

While at it, fix the comment to the teardown_pasta() function.

The new test set can be semi-conveniently run as:

  ./run pasta_options/log_to_file

and it checks basic log creation, size of the log file after flooding
it with debug entries, rotations, and basic consistency after
rotations, on both an existing filesystem and a tmpfs, chosen as
it doesn't support collapsing data ranges via fallocate(), hence
triggering the fall-back mechanism for logging rotation.

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
This commit is contained in:
Stefano Brivio 2022-10-07 02:16:08 +02:00
parent e67039f712
commit d472476caa
5 changed files with 150 additions and 1 deletions
test/lib

View file

@ -106,6 +106,13 @@ setup_pasta() {
wait_for [ -f "${STATESETUP}/passt.pid" ]
}
# setup_pasta_options() - Set up layout and host context without starting pasta
setup_pasta_options() {
context_setup_host host
layout_pasta_simple
}
# setup_passt_in_ns() - Set up namespace (with pasta), run qemu and passt into it
setup_passt_in_ns() {
context_setup_host host
@ -294,7 +301,7 @@ teardown_passt() {
teardown_context_watch ${PANE_GUEST} qemu guest
}
# teardown_passt() - Exit namespace, kill pasta process
# teardown_pasta() - Exit namespace, kill pasta process
teardown_pasta() {
${NSHOLDER} "${STATESETUP}/ns.hold" stop
context_wait unshare
@ -304,6 +311,12 @@ teardown_pasta() {
teardown_context_watch ${PANE_NS} unshare ns
}
# teardown_pasta_options() - Tear down pasta and host context, no namespace
teardown_pasta_options() {
teardown_context_watch ${PANE_HOST} host
teardown_context_watch ${PANE_PASST} passt
}
# teardown_passt_in_ns() - Exit namespace, kill qemu and pasta, remove pid file
teardown_passt_in_ns() {
context_run ns kill $(cat "${STATESETUP}/qemu.pid")