From e6948822ba28387347c6937e370584f9f164d0b3 Mon Sep 17 00:00:00 2001 From: David Gibson Date: Thu, 17 Nov 2022 16:58:37 +1100 Subject: [PATCH] clang-tidy: Suppress warning about assignments in if statements clang-tools 15.0.0 appears to have added a new warning that will always complain about assignments in if statements, which we use in a number of places in passt/pasta. Encountered on Fedora 37 with clang-tools-extra-15.0.0-3.fc37.x86_64. Suppress the new warning so that we can compile and test. Signed-off-by: David Gibson Signed-off-by: Stefano Brivio --- Makefile | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Makefile b/Makefile index 1dc2df5..cc4f014 100644 --- a/Makefile +++ b/Makefile @@ -259,11 +259,16 @@ docs: README.md # - readability-identifier-length # Complains about any identifier <3 characters, reasonable for # globals, pointlessly verbose for locals and parameters. +# +# - bugprone-assignment-in-if-condition +# Dubious value over the compiler's built-in warning. Would +# increase verbosity. clang-tidy: $(SRCS) $(HEADERS) clang-tidy -checks=*,-modernize-*,\ -clang-analyzer-valist.Uninitialized,\ -cppcoreguidelines-init-variables,\ + -bugprone-assignment-in-if-condition,\ -bugprone-macro-parentheses,\ -google-readability-braces-around-statements,\ -hicpp-braces-around-statements,\