mirrors/passt
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tcp, tcp_splice: Adjust comments to current meaning of inbound and outbound

Browse source 
For tcp_sock_init_ns(), "inbound" connections used to be the ones
being established toward any listening socket we create, as opposed
to sockets we connect().

Similarly, tcp_splice_new() used to handle "inbound" connections in
the sense that they originated from listening sockets, and they would
in turn cause a connect() on an "outbound" socket.

Since commit 1128fa03fe ("Improve types and names for port
forwarding configuration"), though, inbound connections are more
broadly defined as the ones directed to guest or namepsace, and
outbound the ones originating from there.

Update comments for those two functions.

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
This commit is contained in:
Stefano Brivio 2022-10-10 19:00:33 +02:00
parent 346da48fe6
commit eab9d8d5d6
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tcp.c
View file

@ -3178,7 +3178,7 @@ void tcp_sock_init(const struct ctx *c, int ns, sa_family_t af,
} }
/** /**
* tcp_sock_init_ns() - Bind sockets in namespace for inbound connections * tcp_sock_init_ns() - Bind sockets in namespace for outbound connections
* @arg: Execution context * @arg: Execution context
* *
* Return: 0 * Return: 0

2
tcp_splice.c
View file

@ -502,7 +502,7 @@ static int tcp_splice_connect_ns(void *arg)
} }
/** /**
* tcp_splice_new() - Handle new inbound, spliced connection * tcp_splice_new() - Handle new spliced connection
* @c: Execution context * @c: Execution context
* @conn: Connection pointer * @conn: Connection pointer
* @port: Destination port, host order * @port: Destination port, host order