From f5d053034c029409115c4daf852d7d118e9bc671 Mon Sep 17 00:00:00 2001 From: David Gibson Date: Wed, 28 Sep 2022 14:33:38 +1000 Subject: [PATCH] Mark unused functions for cppcheck We have a couple of functions that are unused (for now) by design. Although at least one has a flag so that gcc doesn't warn, cppcheck has its own warnings about this. Add specific inline suppressions for these rather than a blanket suppression in the Makefile. Signed-off-by: David Gibson Signed-off-by: Stefano Brivio --- Makefile | 1 - igmp.c | 1 + siphash.c | 1 + 3 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 7b3f8e1..bb349c7 100644 --- a/Makefile +++ b/Makefile @@ -283,7 +283,6 @@ cppcheck: $(SRCS) $(HEADERS) $(SYSTEM_INCLUDES:%=--suppress=*:%/*) \ $(SYSTEM_INCLUDES:%=--suppress=unmatchedSuppression:%/*) \ --inline-suppr \ - --suppress=unusedFunction \ --suppress=unusedStructMember \ \ --suppress=unmatchedSuppression:dhcp.c \ diff --git a/igmp.c b/igmp.c index 2f3a9d1..da7e83d 100644 --- a/igmp.c +++ b/igmp.c @@ -13,4 +13,5 @@ */ /* TO BE IMPLEMENTED */ +/* cppcheck-suppress unusedFunction */ __attribute__((__unused__)) static void unused(void) { } diff --git a/siphash.c b/siphash.c index ec38848..37a6d73 100644 --- a/siphash.c +++ b/siphash.c @@ -177,6 +177,7 @@ uint64_t siphash_20b(const uint8_t *in, const uint64_t *k) * * Return: the 64-bit hash output */ +/* cppcheck-suppress unusedFunction */ uint32_t siphash_32b(const uint8_t *in, const uint64_t *k) { uint64_t *in64 = (uint64_t *)in;