04d3d02603
In tcp_splice_conn_from_sock(), the 'port' variable stores the source port of the connection on the originating side. In tcp_splice_new(), called directly from it, the 'port' parameter gives the _destination_ port of the originating connection and is then updated to the destination port of the connection on the other side. Similarly, in tcp_splice_conn_from_sock(), 's' is the fd of the accetped socket (on side 0), whereas in tcp_splice_new(), 's' is the fd of the connecting socket (side 1). I, for one, find having the same variable name with different meanings in such close proximity in the flow of control pretty confusing. Alter the names for greater specificity and clarity. Signed-off-by: David Gibson <david@gibson.dropbear.id.au> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
19 lines
540 B
C
19 lines
540 B
C
/* SPDX-License-Identifier: GPL-2.0-or-later
|
|
* Copyright (c) 2022 Red Hat GmbH
|
|
* Author: Stefano Brivio <sbrivio@redhat.com>
|
|
*/
|
|
|
|
#ifndef TCP_SPLICE_H
|
|
#define TCP_SPLICE_H
|
|
|
|
struct tcp_splice_conn;
|
|
union sockaddr_inany;
|
|
|
|
void tcp_splice_sock_handler(struct ctx *c, union epoll_ref ref,
|
|
uint32_t events);
|
|
bool tcp_splice_conn_from_sock(const struct ctx *c,
|
|
union tcp_listen_epoll_ref ref, union flow *flow,
|
|
int s0, const union sockaddr_inany *sa);
|
|
void tcp_splice_init(struct ctx *c);
|
|
|
|
#endif /* TCP_SPLICE_H */
|