passt/test/pasta_options/log_to_file
David Gibson ff2ff2fbca test: Make log truncation test more robust
test/pasta_options/log_to_file checks that pasta truncates its log file
when started.  It does that by starting pasta with a log file once, then
starting it again and checking that after the second round, the log file
has only one line: the startup banner from the second invocation.

However, this test will break if the second invocation logs any additional
messages at startup.  This can easily happen on a host with multiple
network interfaces due to the "Multiple default route" informational
messages added in 639fdf06e ("netlink: Fix selection of template
interface").  I believe it could also happen on a host without IPv6
connectivity due to the "Couldn't pick external interface" messages, though
I haven't confirmed this.

Make the log file test more robust, by not testing for a single line, but
instead explicitly testing for the PID of the second pasta invocation in
the banner line.

Link: https://bugs.passt.top/show_bug.cgi?id=88
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
2024-04-25 00:00:34 +02:00

90 lines
2.3 KiB
Text

# SPDX-License-Identifier: GPL-2.0-or-later
#
# PASST - Plug A Simple Socket Transport
# for qemu/UNIX domain socket mode
#
# PASTA - Pack A Subtle Tap Abstraction
# for network namespace/tap device mode
#
# test/pasta_options/log_to_file - Check log creation, rotations and consistency
#
# Copyright (c) 2022 Red Hat GmbH
# Author: Stefano Brivio <sbrivio@redhat.com>
htools wc tcp_rr tail cut tr sort
def flood_log_server
passtb tcp_crr --nolog -P 10001 -C 10002 -6
sleep 1
endef
def flood_log_client
host tcp_crr --nolog -P 10001 -C 10002 -6 -c -H ::1
endef
def check_log_size_mountns
pout SIZE cat __LOG_FILE__ | wc -c
check [ __SIZE__ -gt $((50 * 1024)) ]
check [ __SIZE__ -lt $((100 * 1024)) ]
endef
test Log creation
set PORTS -t 10001,10002 -u 10001,10002
set LOG_FILE __STATEDIR__/pasta.log
passt ./pasta -l __LOG_FILE__ -- /bin/true
check [ -s __LOG_FILE__ ]
test Log truncated on creation
passt ./pasta -l __LOG_FILE__ -- /bin/true & wait
pout PID2 echo $!
check head -1 __LOG_FILE__ | grep '^pasta .* [(]__PID2__[)]$'
test Maximum log size
passtb ./pasta --config-net -d -f -l __LOG_FILE__ --log-size $((100 * 1024)) -- sh -c 'while true; do tcp_crr --nolog -P 10001 -C 10002 -6; done'
sleep 1
flood_log_client
check [ $(cat __LOG_FILE__ | wc -c) -gt $((50 * 1024)) ]
check [ $(cat __LOG_FILE__ | wc -c) -lt $((100 * 1024)) ]
flood_log_client
check [ $(cat __LOG_FILE__ | wc -c) -gt $((50 * 1024)) ]
check [ $(cat __LOG_FILE__ | wc -c) -lt $((100 * 1024)) ]
flood_log_client
check [ $(cat __LOG_FILE__ | wc -c) -gt $((50 * 1024)) ]
check [ $(cat __LOG_FILE__ | wc -c) -lt $((100 * 1024)) ]
pint
test Timestamp consistency after rotations
check tail -n +2 __LOG_FILE__ | cut -f1 -d' ' | tr -d [.:] | sort -c
test Maximum log size on tmpfs (no FALLOC_FL_COLLAPSE_RANGE)
passt unshare -rUm
passt mkdir __STATEDIR__/t
passt mount -t tmpfs none __STATEDIR__/t
set LOG_FILE __STATEDIR__/t/log
passt ./pasta --config-net -d -l __LOG_FILE__ --log-size $((100 * 1024))
flood_log_server
flood_log_client
check_log_size_mountns
flood_log_server
flood_log_client
check_log_size_mountns
flood_log_server
flood_log_client
check_log_size_mountns
test Timestamp consistency after rotations (no FALLOC_FL_COLLAPSE_RANGE)
check tail -n +2 __LOG_FILE__ | cut -f1 -d' ' | tr -d [.:] | sort -c
passtb exit
sleep 1
passt umount __STATEDIR__/t
passt exit